Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve faulty disable of range and score buttons #1421

Merged
merged 1 commit into from
Dec 23, 2024
Merged

resolve faulty disable of range and score buttons #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions activity_browser/docs/wiki/LCA-Results.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ For `Range`, this is the full _range_ of results, for example, if all your negat
and all your positive results together have a score of 10, the _range_ is 12 (-2 * -1 + 10).
For `Score`, this is the total score (sum) of the results, for example, if all your negative results together have a
score of -2 and all your positive results together have a score of 10, the _score_ is 8 (-2 + 10).
The `Range` or `Score` setting are only used when 1) your Cut-off type is `Relative`
and 2) your results contain both positive and negative results.
The `Range` or `Score` setting are only used when your results contain both positive and negative results.

### Positive and negative numbers in contribution results
It can happen in LCA that you get both positive and negative numbers in your contribution results.
Expand Down
6 changes: 0 additions & 6 deletions activity_browser/layouts/tabs/LCA_results_tabs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,12 +1112,6 @@ def update_tab(self):
QApplication.setOverrideCursor(QtCore.Qt.WaitCursor)
self.set_combobox_changes()

if self.cutoff_menu.limit_type == "percent":
self.total_menu.range.setEnabled(True)
self.total_menu.score.setEnabled(True)
else:
self.total_menu.range.setEnabled(False)
self.total_menu.score.setEnabled(False)
super().update_tab()
QApplication.restoreOverrideCursor()

Expand Down
Loading