Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options for legacy biosphere versions to project setup wizard #1314

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Add options for legacy biosphere versions to project setup wizard #1314

merged 3 commits into from
Jun 27, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Jun 26, 2024 •
edited
Loading

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the change PRs related to minor changes to AB label Jun 26, 2024
@mrvisscher mrvisscher added this to the 2.10.0 milestone Jun 26, 2024
@mrvisscher mrvisscher requested a review from marc-vdm June 26, 2024 14:06
@mrvisscher mrvisscher marked this pull request as ready for review June 26, 2024 14:06
marc-vdm
marc-vdm reviewed Jun 27, 2024
View reviewed changes
Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, except 1 minor comment below

activity_browser/mod/bw2io/__init__.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 54.398% (-0.08%) from 54.477%
when pulling 56c9f7c on mrvisscher:legacy_biosphere_setup
into ab9cdaa on LCA-ActivityBrowser:main.

@coveralls
Copy link

Coverage Status

coverage: 54.398% (-0.08%) from 54.477%
when pulling 91936c0 on mrvisscher:legacy_biosphere_setup
into ab9cdaa on LCA-ActivityBrowser:main.

@mrvisscher mrvisscher merged commit 5a6b623 into LCA-ActivityBrowser:main Jun 27, 2024
9 checks passed
@mrvisscher mrvisscher deleted the legacy_biosphere_setup branch June 27, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vdm marc-vdm marc-vdm left review comments

Assignees
No one assigned
Labels
change PRs related to minor changes to AB
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mrvisscher @coveralls @marc-vdm