Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Scenario excel file import bug #1050

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

Zoophobus
Copy link
Contributor

In the import procedure for the files the AB excel module was being used, this however was limited to the import of the scenario difference file format and not the parameter scenario format, breaking the import procedure for scenario parameter files. This removes this condition in the excel module and keeps the file checks to the same location.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog

@Zoophobus Zoophobus added the bug Issues/PRs related to bugs label Sep 22, 2023
@coveralls
Copy link

Coverage Status

coverage: 50.446% (-0.07%) from 50.513% when pulling d8fbe1e on Zoophobus:excel_import_bug into 1715a17 on LCA-ActivityBrowser:master.

@marc-vdm marc-vdm added this to the 2.9.1 milestone Sep 22, 2023
@marc-vdm marc-vdm merged commit d90f7ea into LCA-ActivityBrowser:master Sep 25, 2023
@marc-vdm marc-vdm changed the title Excel import bug Parameter Scenario excel file import bug Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants