TS-1631: Display multiple pending contracts for the same property #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/TS-1631
Describe this PR
What is the problem we're trying to solve
On BTA, the Contracts approval Worktray relies on the Housing Search system to display what contract belongs to which asset. Currently, only the latest contract is saved by the Listener, however, in some instances, BTA users will need to approve more than one contract on the same property. This happens, for example, if a tenant moves in and out of the property in a matter of days: since the contract approval is not guaranteed to be done on a daily basis, those contracts would not be approved in time.
The changes in this and following PRs will move
AssetContractproperty on theAssetentity from a single one to a list ofAssetContracts.What changes have we introduced
Change from single AssetContract to list of AssetContracts where needed.
Follow up actions after merging PR
Updates to Listener and API.