Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

add hotjar and feeback google form btn #5

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

rik86future
Copy link
Contributor

@rik86future rik86future commented Aug 14, 2020

What
Adds a Submit feedback btn to a google form and a HotJar tracking script
image

image

Why
For user Testing

Anything else?

  • Have you added any new third-party libraries?
  • Are any new environment variables or configuration values needed?
  • Anything else in this PR that isn't covered by the what/why?

Copy link
Contributor

@kjdchapman kjdchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With no env-vars, I'm guessing this is exposing our hotjar ID/key (or similar)?

I doubt anyone will submit fake hotjar data, so I'm happy with doing it in the short-term. Probably good to move it at some point.

@rik86future
Copy link
Contributor Author

With no env-vars, I'm guessing this is exposing our hotjar ID/key (or similar)?

I doubt anyone will submit fake hotjar data, so I'm happy with doing it in the short-term. Probably good to move it at some point.

@rik86future rik86future reopened this Aug 14, 2020
@rik86future
Copy link
Contributor Author

With no env-vars, I'm guessing this is exposing our hotjar ID/key (or similar)?

I doubt anyone will submit fake hotjar data, so I'm happy with doing it in the short-term. Probably good to move it at some point.

Good shout I should fix this

@rik86future rik86future requested a review from kjdchapman August 14, 2020 09:27
Copy link
Contributor

@kjdchapman kjdchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this google form only allow responses from .hackney.gov.uk emails?

(LGTM either way!)

@@ -47,6 +47,7 @@ jobs:
export AIRTABLE_TABLE_NAMES=${AIRTABLE_TABLE_NAMES_INTEGRATION}
export ADDRESSES_API_URL=${ADDRESSES_API_URL}
export ADDRESSES_API_KEY=${ADDRESSES_API_KEY}
export HOTJAR_ID=${HOTJAR_ID}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting my head around the split configuration - I see no reason why this shouldn't work, but if it doesn't, that'd be my first suspicion!

@rik86future rik86future merged commit 8362147 into master Aug 14, 2020
@elena-vi elena-vi deleted the 82-add-hotjar-for-tracking-snapshot-usage branch March 18, 2021 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants