Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/larpandoracontent_v04_11_00 #67

Merged
merged 36 commits into from
Oct 22, 2024
Merged

feature/larpandoracontent_v04_11_00 #67

merged 36 commits into from
Oct 22, 2024

Conversation

AndyChappell
Copy link

This PR for larpandoracontent version v04_11_00 contains updates to support supernova neutrino reconstruction and updates to provide Pandora metric calculations that can be backward compatible with legacy metrics. This PR depends upon a feature added in larpandora PR 42.

jback08 and others added 30 commits September 9, 2024 08:36
@jback08 @AndyChappell
LArHierarchyHelper: Allow selecting reco hits to only those that come…
cf38d24 
… from the MC particles.

Add SelectRecoHits bool parameter to the HierarchyValidationAlgorithm (defaults to false).
@jback08 @AndyChappell
Clang formatting
08c2a6e
@jback08 @AndyChappell
Soft tabs formatting.
e9c5083
@MattOsbiston @AndyChappell
Updated CheatingClusterMergingAlg using MC Truth to cluster
aa938dc
@MattOsbiston @AndyChappell
Lowered thresholds in LArMCParticleHelper.cc for LowE
4910dc3
@AndyChappell
MVA LowE Cluster Algorithm Added
0031101
@MattOsbiston @AndyChappell
Updates to algorithms to ensure workflow compatability
77c4a23
@MattOsbiston @AndyChappell
corrections to algs for syntax error
325c1be
@MattOsbiston @AndyChappell
Addition of DLSignalAlgorithm
f5b9a41
@AndyChappell
modifications to DlSignalAlg for SCaloHitListX creation
e9065b7
@MattOsbiston @AndyChappell
Latest updates for low energy signal and background use
ff6bf28
@MattOsbiston @AndyChappell
Latest bug fixes for LowE
25344c1
@MattOsbiston @AndyChappell
Latest bug fixes to metrics for low energy to account for events with…
da9337f 
…out Pfos
@MattOsbiston @AndyChappell
removed unnecessary printout from CheatingPfoCreationAlgorithm
a0d54d2
@AndyChappell
removed LowEClusterAlg (obsolete alg) from LArContent as still existe…
895e1f4 
…d locally
@MattOsbiston @AndyChappell
Changes required according to previously submitted pr #217 - that pr …
4a747a3 
…will be closed, will all changes added to this pr
@AndyChappell
mainly presentational changes to MVAClusterMergingAlg. I did spot an …
d1b42d0 
…error in the edgehit finder tool, where the sectors are defined using a vector which rotates to define the segments, this was rotating in the x-y plane, not the x-z plane as all other vectors are defined
@AndyChappell
removed condition for adding vtxClusterAngle to root tree as variable…
51aab3a 
… is always initialised
@AndyChappell
moved clusterMC and otherClusterMC calls inside the loop which only r…
12b48c8 
…uns during training, removing unnecessary loop during reconstruction
@MattOsbiston @AndyChappell
fixed compiling errors
f4d72c0
@MattOsbiston @AndyChappell
Addressed Andy C's comments for pr 226, mainly formatting, but also m…
9ab382f 
…ade some logic more concise and added in cluster existance and size checks in MVAClusterMergingAlg
@MattOsbiston @AndyChappell
modification for compilation errors, addressing pr comments, and incl…
a235a23 
…uding files with neutrino2 a changes for testing and validation - will remove these on the final commit
@AndyChappell
Changes to DLSigal - Noticed missing assignment of 0 for background p…
9620fdf 
…articles that have MC to the .csv file, reducing the number of processable files by the network
@AndyChappell
Addressed the comments for pr #226 and also some minor additions to t…
2c6203b 
…he DLSignalAlg for particle monitoring, enabling distinguishment betweens photons and electrons, both in MC and decided by the network
@AndyChappell
renaming of DlSignalAlgorithm to DlSNSignalAlgorithm
29abf12
@AndyChappell
Revert IsNeutrino calls given new sn neutrino support from related la…
9854fa7 
…rpandora PR
@AndyChappell
Addition of isSignal variable to HierarchyValidationAlg, and modifica…
9a94d7d 
…tion to vertex definitions
@AndyChappell
Additional of mc and reco Mip Equivalent Energy Variables
e0001ca
@AndyChappell
Modification to InteractionDescriptor and variable assignment due to …
0ecbf84 
…non-compatibility with backgrounds in LowE
@AndyChappell
numerous fixes for compiliation errors
6f209e6
@FNALbuild
Copy link

+code-checks

@lgarren
Copy link
Member

lgarren commented Oct 21, 2024

trigger build with pull requests #67, LArSoft/larpandora#42

@FNALbuild
Copy link

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larpandora#42

@FNALbuild FNALbuild mentioned this pull request Oct 21, 2024
Merged
@FNALbuild
Copy link

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/23982&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

1 similar comment
@FNALbuild
Copy link

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/23982&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

@FNALbuild
Copy link

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/23981&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

1 similar comment
@FNALbuild
Copy link

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/23981&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

@FNALbuild
Copy link

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/15206&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

1 similar comment
@FNALbuild
Copy link

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/15206&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

@FNALbuild
Copy link

-ICARUS tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/10810&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

1 similar comment
@FNALbuild
Copy link

-ICARUS tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/10810&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

@FNALbuild
Copy link

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/11292&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

1 similar comment
@FNALbuild
Copy link

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/11292&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

@FNALbuild
Copy link

-DUNE tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/18040&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

1 similar comment
@FNALbuild
Copy link

-DUNE tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/18040&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23981&builds=

@lgarren
Copy link
Member

lgarren commented Oct 21, 2024

approve

@FNALbuild
Copy link

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit fa6726e into LArSoft:develop Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed L1-approved L2-approved requires-external tests-started
Projects
LArSoft pull requests
Status: Included in release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndyChappell @FNALbuild @lgarren @jback08 @MattOsbiston