Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUNE FD Production phase 2 release #58

Merged
merged 12 commits into from
Nov 1, 2023

Conversation

AndyChappell
Copy link

@AndyChappell AndyChappell commented Oct 30, 2023

This PR contains updates to address the large difference between strip pitches in the induction and collection planes in the vertical drift detector. These updates alter the behaviour of clustering in detectors where differences in wire/strip pitches between planes exist and therefore product changes are expected. Please tag this as v04_06_00.

@knoepfel
Copy link
Member

trigger build

@FNALbuild
Copy link

The tests are being triggered in jenkins.

@FNALbuild
Copy link

A new Pull Request was created by @AndyChappell for develop.

It involves the following packages:

larpandoracontent

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link

+code-checks

@FNALbuild
Copy link

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20864&builds=
+build

@FNALbuild
Copy link

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20865&builds=
+build

@FNALbuild
Copy link

@FNALbuild
Copy link

@FNALbuild
Copy link

@FNALbuild
Copy link

-dune tests tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:dune/view_builds/index?offset=0&builds=dune_ci/16305&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/20865&builds=

@lgarren
Copy link
Member

lgarren commented Oct 30, 2023

approve

@FNALbuild
Copy link

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit b55fbe8 into LArSoft:develop Nov 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Included in release
Development

Successfully merging this pull request may close these issues.

4 participants