-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insight wrapper #229
Merged
MaxThevenet
merged 20 commits into
LASY-org:development
from
hightower8083:insight-wrapper2
Jun 12, 2024
Merged
Insight wrapper #229
MaxThevenet
merged 20 commits into
LASY-org:development
from
hightower8083:insight-wrapper2
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
added comments to the code
for more information, see https://pre-commit.ci
added check-and-correct procedure for complex field convention
for more information, see https://pre-commit.ci
…nsight-wrapper2
added optional methods for central frequency selection
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nsight-wrapper2
I think this one is ready for reviewing/merging @MaxThevenet |
MaxThevenet
reviewed
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! See minor comments below.
all good to me Co-authored-by: Maxence Thévenet <maxence.thevenet@desy.de>
MaxThevenet
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to read insight data from HDF5 file generated by the SourceLab intreface. Based on the generic FromArray profie