Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insight wrapper #229

Merged
merged 20 commits into from
Jun 12, 2024
Merged

Conversation

hightower8083
Copy link
Member

Added a method to read insight data from HDF5 file generated by the SourceLab intreface. Based on the generic FromArray profie

@hightower8083 hightower8083 added the new feature request or implementation of a new feature label Feb 15, 2024
@hightower8083 hightower8083 changed the title [WIP] Insight wrapper Insight wrapper Mar 21, 2024
@hightower8083
Copy link
Member Author

I think this one is ready for reviewing/merging @MaxThevenet

Copy link
Contributor

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! See minor comments below.

lasy/profiles/from_insight_file.py Outdated Show resolved Hide resolved
lasy/profiles/from_insight_file.py Outdated Show resolved Hide resolved
lasy/profiles/from_insight_file.py Outdated Show resolved Hide resolved
lasy/profiles/from_insight_file.py Outdated Show resolved Hide resolved
hightower8083 and others added 2 commits June 11, 2024 10:32
all good to me

Co-authored-by: Maxence Thévenet <maxence.thevenet@desy.de>
@MaxThevenet MaxThevenet merged commit 154b803 into LASY-org:development Jun 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request or implementation of a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants