V1.9.5 #5
V1.9.5 #5
Conversation
…and MacOs the current version of gcc and will update it, EXPERIMENTAL FEATURE this has not been tested yet.
R/getGfortran.R
Outdated
| #' @author Michael Neely | ||
| #' @export | ||
|
|
||
| updateGfortran <- function() { |
There was a problem hiding this comment.
@mnneely What do you think about this function name?
There was a problem hiding this comment.
It seems like the underscore is becoming the convention for naming variables, functions, etc. in R?
| updateGfortran <- function() { | |
| update_gfortran <- function() { |
There was a problem hiding this comment.
Should it have a prefix? like PMupdate_gfortran?
There was a problem hiding this comment.
Here's a nice coding convention reference. As you can tell, I developed things a long time ago. I would not suffix items as op.1 now. I would call it op_1.
https://www.r-bloggers.com/🖊-r-coding-style-guide/
|
Now we are supporting install_gfortran in both Mac and windows, linux would be a little bit harder because the commands will depend on the package manager the user is using. I also included the script to remove the gfortran installation from the system. but I'm not sure how to proceed. should we also uninstall choco/brew ? @mnneely |
|
The removal is to remove other gfortran installations? I don't think we need to remove choco/brew. |
|
No, I was thinking about the user that want to uninstall all the dependencies pmetrics uses to setup gfortran |
|
So install gfortran, but then remove choco/brew. But then they won’t be able to update gfortran.
I guess we could warn them of that fact...
…___________________________________________
Michael Neely, MD, MSc, FCP
Chief, Infectious Diseases
Director, Laboratory of Applied Pharmacokinetics and Bioinformatics
Children’s Hospital Los Angeles
Professor of Pediatrics and Clinical Scholar
Keck School of Medicine
University of Southern California
On May 5, 2020, at 3:50 PM, Julian Otalvaro <notifications@github.com> wrote:
No, I was thinking about the user that want to uninstall all the dependencies pmetrics uses to setup gfortran
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/LAPKB/Pmetrics/pull/5*issuecomment-624347071__;Iw!!LIr3w8kk_Xxm!8-6hc-KGt09Z-mupDFmW9NDeym8BJ7ahrdrGD1JlOI8wskA5f16x2C9C0A3sOA$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AB6CLTVV2GUKSIOFESCD6GDRQCJ3NANCNFSM4MKDLB7A__;!!LIr3w8kk_Xxm!8-6hc-KGt09Z-mupDFmW9NDeym8BJ7ahrdrGD1JlOI8wskA5f16x2C8GJInsyA$>.
|
Merge branch 'master' of github.com:LAPKB/Pmetrics # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…and MacOs the current version of gcc and will update it, EXPERIMENTAL FEATURE this has not been tested yet.
…port /w styles also if they dont have pmetrics installed (remote execution)
fixed bug if >1 output equation
Goal: provide the user with the possibility of update gfortran within Pmetrics.
This should close #4