Add RoPE Interpolation #3564
Merged
Add RoPE Interpolation #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahules786
requested review from
theblackcat102,
sanagno,
dvruette,
andreaskoepf and
yk
as code owners
|
❌ pre-commit failed. |
andreaskoepf
requested changes
Jul 12, 2023
| @@ -779,3 +782,32 @@ debug: | |||
| verbose: true | |||
| num_train_epochs: 0.2 | |||
| dtype: fp32 | |||
|
|
|||
| patching-test: | |||
There was a problem hiding this comment.
Could we change the name to something like "rope_scaling_test"?
model/model_training/trainer_sft.py
Outdated
| model = get_model(training_conf, tokenizer) | ||
|
|
||
| from model_training.models.patching import RopePatch |
There was a problem hiding this comment.
Is there a benefit of late import, otherwise I would recommend to move this to the other imports at the beginning of the file (to make it easier to see all main dependencies).
andreaskoepf
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for RopE interpolation via the SuperHOT method and its variants proposed in
reddit
scaled-rope
Supported methods
Supported Models
This can be easily extended and experimented with by configuring two parameters
superhotandsuperhot_config