Add return value in prepare_tensor #3327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no return value in
prepare_tensor
Open-Assistant/model/model_training/utils/utils_rl.py
Lines 5 to 7 in 0fcf3e0
so it will raise
None type error
while RLHF trainingOpen-Assistant/model/model_training/utils/ppo_utils.py
Lines 553 to 561 in 0fcf3e0
Open-Assistant/model/model_training/trainer_rl.py
Lines 93 to 99 in 0fcf3e0