Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch flake8 by ruff #3323

Merged
merged 4 commits into from
Jun 8, 2023
Merged

ci: switch flake8 by ruff #3323

merged 4 commits into from
Jun 8, 2023

Conversation

andreaskoepf
Copy link
Collaborator

@andreaskoepf andreaskoepf commented Jun 7, 2023

This PR supersedes #1159 (cloned OA repo was archived by original PR author).
Original text by Borda:

Ruff aims to be orders of magnitude faster than alternative tools while integrating more functionality behind a single, common interface.
Ruff can be used to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing tens or hundreds of times faster than any individual tool.

Also, I would suggest installing pre-commit bot, which helps to fix code within each PR so, lowering developer overhead... see: https://pre-commit.ci/

@Borda
Copy link
Contributor

Borda commented Jun 7, 2023

cloned OA repo was archived by original PR author

I would unarchive if you would say that we may continue and eventually land the original PR :)

@andreaskoepf
Copy link
Collaborator Author

@Borda … your commits are in the new PR, I just merged main to ensure that pre-commit is passing with the latest source revision… which it is. Thanks again.

Copy link
Collaborator

@yk yk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you

@andreaskoepf andreaskoepf merged commit a226633 into main Jun 8, 2023
@andreaskoepf andreaskoepf deleted the use_ruff_linter branch June 8, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants