-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show hidden chats in chat list #3075
Conversation
@@ -184,4 +184,5 @@ export interface GetChatsParams { | |||
limit?: number; | |||
before?: string; | |||
after?: string; | |||
include_hidden?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have an option to only show hidden chat, since include_hidden will result in all chats, we still have to make the UI to show whether the chat is hidden or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, this will require some changes in the backend, so I am going to move it to a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to work in the inference backend, I suggest we have a filter like this, and apply when it is not null
type Filter = {
hidden?: boolean
allow_data_use?: boolean
shared?: boolean // future
}
So the user can compose the filter they want. I can work on the frontend UI
> | ||
{t("create_chat")} | ||
</CreateChatButton> | ||
{allowHiddenChats && <ChatHiddenSwitch onChange={setIncludeHidden} value={includeHidden} />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make it a selection instead? So user can select visible chat, hidden chat, trainable chat, and maybe shared chat in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, added!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Also removed outdated
initialChats
since we fetch everything client side now.Desktop:
Mobile:
Currently only enabled in development since some features are still missing.
Blocked by #3050