Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify default post_create_command.sh #2970

Merged
merged 1 commit into from
Apr 30, 2023
Merged

simplify default post_create_command.sh #2970

merged 1 commit into from
Apr 30, 2023

Conversation

andrewm4894
Copy link
Collaborator

I have been trying to use default codespace for testing some PR's and finding it somewhat impossible to use in github codespaces as it seems to be trying to do too much automatically.

  • we should run as little as possible in the default devcontainer to make it as fast and easy to get going with.
  • if does not make sense to run the post create scripts of the other devcontainers, their own devcontainer.jsons call those scripts themselves.

@andrewm4894 andrewm4894 marked this pull request as ready for review April 29, 2023 11:05
@andrewm4894 andrewm4894 enabled auto-merge (squash) April 29, 2023 11:05
@andrewm4894 andrewm4894 mentioned this pull request Apr 29, 2023
Closed
@andrewm4894 andrewm4894 merged commit c77f710 into LAION-AI:main Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaskoepf andreaskoepf andreaskoepf approved these changes

@yk yk Awaiting requested review from yk yk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewm4894 @andreaskoepf