Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning message near chat window about model hallucinations #2794

Merged
merged 13 commits into from
Apr 25, 2023

Conversation

Quarks-1
Copy link
Contributor

Referencing issue #2756 , this is my current progress
image
Would love some feedback!

@Quarks-1
Copy link
Contributor Author

This is the dark mode version:
image

@Quarks-1
Copy link
Contributor Author

Also, I am currently using this as the warning image, however, if there is an internal one that works better I'm happy to replace it.

Copy link
Collaborator

@notmd notmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but I want to hold this until #2741 get merged

website/src/data/team.json Outdated Show resolved Hide resolved
@yk
Copy link
Collaborator

yk commented Apr 21, 2023

I'm not against this per se, but do we really have this low hopes for humanity?...

@andreaskoepf
Copy link
Collaborator

I'm not against this per se, but do we really have this low hopes for humanity?...

I think this is really important as some outputs may look good, people are confused and see for example #2751 . We should also state that the assistant has no internet access .. I saw at least 3 different videos which either in the video or later "as correction in the comments" stated that OA would have internet access .. probably mainly because our mission-statement and the docs page say this. Also more ordinary people without ML/NLP experience or children might start using the system who have not heard about the hallucination problem.

I am not 100% happy with the current text proposal for the message, maybe could @olliestanley or someone else who is native speaker please make a proposal for the message?

@andreaskoepf
Copy link
Collaborator

btw I think we should also add a message to encourage users to give feedback with thumbs up/down for generated messages.

@Quarks-1
Copy link
Contributor Author

@andreaskoepf Could we make the message to encourage users to give feedback a new issue since it is not directly related to this issue?

@olliestanley
Copy link
Collaborator

Could we make the message to encourage users to give feedback a new issue since it is not directly related to this issue?

Yes that would be fine

@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

1 similar comment
@github-actions
Copy link

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@Quarks-1
Copy link
Contributor Author

Quarks-1 commented Apr 23, 2023

I've synced my fork and it seems like changes were pushed to main that don't pass pre-commit. These errors aren't related to the changes I've made @andreaskoepf
I've moved all of my changes to separate components so it should be good to go now!

@olliestanley
Copy link
Collaborator

I've synced my fork and it seems like changes were pushed to main that don't pass pre-commit. These errors aren't related to the changes I've made @andreaskoepf I've moved all of my changes to separate components so it should be good to go now!

pre-commit is passing on latest main. It looks like pre-commit's main issues for this PR are these:

./src/components/Chat/ChatSection.tsx
37:8  Error: 'Card' is not defined.  react/jsx-no-undef
38:10  Error: 'CardBody' is not defined.  react/jsx-no-undef
41:12  Error: 'Divider' is not defined.  react/jsx-no-undef

Other messages are just Warning

@notmd
Copy link
Collaborator

notmd commented Apr 23, 2023

Hi, can you change the design to something like OAI does?
image

@andreaskoepf
Copy link
Collaborator

andreaskoepf commented Apr 23, 2023

Hi, can you change the design to something like OAI does?

I think in a first step we should get this warning in. @notmd you can make a design proposal for something different (later in separate PR), but IMO there are things like inference feedback collection which by far are more important .. we should discuss that via discord.

@Quarks-1 could you please address the pre-commit errors:

./src/components/Chat/ChatSection.tsx
1:1  Warning: Run autofix to sort these imports!  simple-import-sort/imports
37:8  Error: 'Card' is not defined.  react/jsx-no-undef
38:10  Error: 'CardBody' is not defined.  react/jsx-no-undef
41:12  Error: 'Divider' is not defined.  react/jsx-no-undef

thx!

@Quarks-1
Copy link
Contributor Author

Quarks-1 commented Apr 23, 2023

image

Here is the new warning to work with the codebase changes
The warning image still needs to be added to the internal github storage I believe, so a placeholder is there and can be easily changed by someone if necessary. It can be found in website/src/data/warning.json

@olliestanley
Copy link
Collaborator

I am not 100% happy with the current text proposal for the message, maybe could @olliestanley or someone else who is native speaker please make a proposal for the message?

I can do this tomorrow, in the meantime we could merge this PR and I could submit a separate PR, either way is fine

@Quarks-1
Copy link
Contributor Author

@olliestanley If there is a specific message you would like to have instead I am happy to replace it!

@andreaskoepf
Copy link
Collaborator

@olliestanley I think we could merge it now and you could maybe tweak the message a bit in a separate PR. @notmd if you are ok with the overall approach, e.g. using the TeamMember component here, it could be merged.

@olliestanley
Copy link
Collaborator

@olliestanley If there is a specific message you would like to have instead I am happy to replace it!

As Andreas said, many people may not understand what "hallucination" is in this context. It's also not (yet) really true to say that safeguards have been put in place.

As a first draft I would consider something like:

This Assistant is a demonstration version that does not have internet access. It may generate incorrect or misleading information. It is not suitable for important use cases or for giving advice.

We can tweak this further later if needed.

@Quarks-1
Copy link
Contributor Author

Sounds good, makes sense to make a separate PR then.

@Quarks-1 Quarks-1 requested a review from notmd April 24, 2023 03:09
Copy link
Collaborator

@AbdBarho AbdBarho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need a design update, since this will block the majority of the screen for mobile users.

@olliestanley olliestanley merged commit 358a09a into LAION-AI:main Apr 25, 2023
grgau pushed a commit to grgau/Open-Assistant that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants