Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Markdown'ed links more noticeable #3082

Closed
echo0x22 opened this issue May 8, 2023 · 6 comments · Fixed by #3222
Closed

Make Markdown'ed links more noticeable #3082

echo0x22 opened this issue May 8, 2023 · 6 comments · Fixed by #3222
Assignees
@kayjay-is-here
Labels
UI/UX All website Components website

Comments

@echo0x22
Copy link
Contributor

echo0x22 commented May 8, 2023 •
edited
Loading

(Both for Chat and Tasks) For now, you can notice them only by bold text. I suggest adding colors or underline them. For GH it's: Google
Screenshot_20230508-032329_Bromite
@echo0x22 echo0x22 changed the title Make Markdown'ed links more noticable. Make Markdown'ed links more noticable May 8, 2023
@kayjay-is-here
Copy link
Contributor

I can do this if you assign this to me.

@olliestanley olliestanley added website UI/UX All website Components labels May 8, 2023
kayjay-is-here added a commit to kayjay-is-here/Open-Assistant that referenced this issue May 12, 2023
@kayjay-is-here
LAION-AI#3082 PR (Please Test First)
c71837e 
I could not, after hours, get Docker to cooperate and let me access the website. So with how simple this change is, I, after much deliberation and exasperation, have decided that it probably works. But on the off chance it doesn't can somebody please run this and make sure it actually works as intended?
@kayjay-is-here
Copy link
Contributor

bump

@mashdragon
Copy link
Contributor

mashdragon commented May 21, 2023 •
edited
Loading

bump

I don't think you actually opened a PR yet @kayjay-is-here

@kayjay-is-here
Copy link
Contributor

I want to say that I've just been having technical difficulties in getting Docker to cooperate, so given how small the change for this project is, you may want to simply check out my PR and test it yourself, or assign this project to someone who has a functioning deployment enviorment.

Sorry for the bad communication, kind of forgot about this.

@echo0x22
Copy link
Contributor Author

image
image

It works only for confirmation 😢
I'm going to make it as you're having problems with docker

@echo0x22
Copy link
Contributor Author

image
Done ig

@echo0x22 echo0x22 changed the title Make Markdown'ed links more noticable Make Markdown'ed links more noticeable May 24, 2023
@echo0x22 echo0x22 mentioned this issue May 24, 2023
Merged
notmd pushed a commit that referenced this issue May 24, 2023
@echo0x22
Add noticeable links, extract "Sponsored", fix ru (#3222)
42c8512 
Changes
1. Made links more noticeable [ Resolves
/issues/3082 ]
2. Extracted "`Sponsored by`" locale
3. Fixed typo in RU (didn't translate "`plugin`")

---


![image](https://github.com/LAION-AI/Open-Assistant/assets/122345469/0f034f82-27e9-42f2-afbf-e7bd019edc4f)

![image](https://github.com/LAION-AI/Open-Assistant/assets/122345469/908efbb4-6144-4e50-8e7c-5efa55c27b71)

![image](https://github.com/LAION-AI/Open-Assistant/assets/122345469/00747643-66aa-41ad-98d1-770837c2bf5f)

Co-authored-by: 0x22almostEvil <0x22almostEvil>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kayjay-is-here kayjay-is-here

Labels
UI/UX All website Components website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add noticeable links, extract "Sponsored", fix ru echo0x22/Open-Assistant
4 participants
@olliestanley @kayjay-is-here @echo0x22 @mashdragon