Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Set 9 Improvements #183

Merged
merged 9 commits into from
Jun 17, 2023
Merged

Set 9 Improvements #183

merged 9 commits into from
Jun 17, 2023

Conversation

akshualy
Copy link
Collaborator

@akshualy akshualy commented Jun 15, 2023

improvements

Description

A few changes to be more in line with changes done in Set 9.

  1. Gives the load screen up to 5 minutes to load. This is to improve the accuracy of the "Did not detect game start" message, but also helps with the next improvement.
  2. Replaces shared draft logic upon game start with the new voting mechanic, where everyone votes on a "quirk" for the game. Probably not necessary, but looks quite good, since your little legend auto-walks to the vote area.
  3. Improves the round 5+ elder dragon round captures, I didn't reach it when I initially updated them, so doing it now.
  4. Refactors randomness when moving and clicking with the mouse. I noticed that if the random method is called in the method arguments as a default value, the value never changes. In addition, we are now going back to randomly clicking within a found image. This has been missing somehow since we refactored the click helpers.
  5. Re-enables button based surrender. It's way more reliable than chat-based surrender, which was only a temporary fix anyway.
  6. Checks for aguments before surrendering. There is much more time to select an augment in Set 9, so this prevents an overlap that'd result in issues with surrendering.
  7. Fixes an exception that could happen when calculating unit positions on the board. I'll address the rest of the unit/item stuff in another PR, but wanted to fix the exception.

@akshualy akshualy requested a review from Kyrluckechuck June 15, 2023 16:08
Copy link
Owner

@Kyrluckechuck Kyrluckechuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, sad to see some of this going but I knew for a bit it was time to start refactoring this stuff, so thanks for getting the ball rolling on that! 😅

@Kyrluckechuck Kyrluckechuck merged commit d30375d into main Jun 17, 2023
@Kyrluckechuck Kyrluckechuck deleted the Set-9-Improvements branch June 17, 2023 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants