This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Catch more errors #135
Merged
Catch more errors #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try: | ||
| sys.exit(main()) | ||
| except KeyboardInterrupt: | ||
| logger.info("Received wish to exit by CTRL+C, exiting immediately.") |
There was a problem hiding this comment.
One nice QoL thing might be to just do a final print_timer() -- what do you think? 😛
There was a problem hiding this comment.
Hm, you'd probably not see that unless you're running from source. In addition, the "intended" way to exit is to enable the "stop queueing" logic, and then to Ctrl+C or close the window, which would print it twice :/
There was a problem hiding this comment.
Fair enough -- I sometimes interrupt it mid-game and then surrender manually, so was thinking of that use case, but it's fairly minor 😛
There was a problem hiding this comment.
Hm, I think we can improve this catch to see from which logic step it was called, so maybe we can add it as a small improvement in another PR :)
Kyrluckechuck
approved these changes
Apr 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds changes that catch some new errors that may occur since we switched to HTTP requests.
We now also catch KeyboardInterrupt to correctly display that we know we should exit instead of printing a random stack trace.
In addition, a fix has been added to check if our session has expired.
Fixes #133
Fixes #134