Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Make wanted traits configurable #126

Merged
merged 5 commits into from
Apr 9, 2023
Merged

Conversation

akshualy
Copy link
Collaborator

@akshualy akshualy commented Apr 8, 2023

Description

Adds wanted_traits and purchase_traits_in_prioritized_order to the configuration. Documents both in the README and the config itself.

wanted_traits is a 1:1 replacement for the field WANTED_TRAITS in constants.py.
purchase_traits_in_prioritized_order is a new configuration option that I thought would make sense. It makes the behavior configurable, in which currently, a trait in the list is only bought if the trait that comes before it was found. For example, at the moment, a brawler unit is only purchased if a duelist unit is bought.

Addresses one of the tasks in #124.

Notes

Deletes the Previous Patch folder in the trait captures. If we need them, we can refer to git history.

Copy link
Owner

@Kyrluckechuck Kyrluckechuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fixes & good cleanup, thank you! 🧹

tft_bot/config.py Show resolved Hide resolved
tft_bot/resources/config.yaml Show resolved Hide resolved
@akshualy
Copy link
Collaborator Author

akshualy commented Apr 9, 2023

As mentioned in the discussion above, we can now see our win rate in the game-end overview.

It is worth noting that this doesn't immediately update upon losing since a game must end entirely to show up in the match history. This effectively means it's off by one game on average, which should be fine in the long run.

We likely won't be able to sustain anything much higher than 50% since Elo is a thing 😞 But at least now we know! 🎉

grafik
grafik

@Kyrluckechuck Kyrluckechuck merged commit 325efaf into main Apr 9, 2023
@Kyrluckechuck Kyrluckechuck deleted the Make-Wanted-Traits-Configurable branch April 9, 2023 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants