This repository has been archived by the owner on Apr 20, 2024. It is now read-only.
Add update notifier #125
Merged
Add update notifier #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses "Version detection" of #124. It makes more sense to keep the config versioning separate from the project versioning, so we do not update the config for updates that do not edit it.
Implements a version update notifier by sending an API request to this repository's latest release, comparing the tag with the string in the
VERSIONfile. The comparison ignores everything in the semantic version after thepatchsegment (position 3).When a new version is detected, the user will be notified on start-up through a pop-up detailing their and the repository's version. They may download it (the button opens the release page in their default browser) or ignore it.
I decided to implement this first since it seems that we have had quite a few releases recently :)
Notes
Usually, you would add a checkbox denoting an option to ignore the update until the following remote version change. However, this is not possible with the limited GUI scope we have at the moment. I might be wrong, though, so feel free to point it out if you know if it is possible off the top of your head!
Out-of-scope commit that marks the executable to be run as administrator. This prevents the obligatory "Have you tried running as administrator?" question if someone opens an issue.