Repurpose -a to mean --advanced_conf_file as --app_config is unused #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally used Currently the -a flag is not used. Originally introduced in [1], it [seemingly] was meant to allow for app.config location customization. That never materialized as the flag is not used anywhere in the codebase besides the getopt definition. Instead we repurpose -a to mean --advanced_conf_file, which was adopted in a fork currently bundled with RabbitMQ. Having a hardcoded location for advanced.config is primarily inconvenient in integration tests that generate configuration files. Note that --app_config has been removed. The version will be bumped to 2.3.0. Per discussion with @dcorbacho @kjnilsson @lukebakken. 1. basho/cuttlefish@106b8b7
lukebakken
approved these changes
Aug 7, 2019
|
cuttlefishes.zip contains a test setup I've been using. The |
|
Doh, too late :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the -a flag is not used. Originally introduced in [1],
it [seemingly] was meant to allow for app.config location customization.
That never materialized as the flag is not used anywhere in the codebase
besides the getopt definition.
Instead we repurpose -a to mean --advanced_conf_file, which was adopted
in a fork currently bundled with RabbitMQ. Having a hardcoded location
for advanced.config is primarily inconvenient in integration tests
that generate configuration files.
Note that --app_config has been removed. The version will be bumped to
2.3.0.
Per discussion with @dcorbacho @kjnilsson @lukebakken.