Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable build on Windows #3

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Enable build on Windows #3

merged 1 commit into from
Aug 5, 2019

Conversation

lukebakken
Copy link
Collaborator

@lukebakken lukebakken commented Aug 5, 2019

Hello @Licenser !

In erlang-lager/lager#509 I'm fixing lager to run correctly on Windows. I prepared #2 on Windows, actually, and would like to contribute a configuration file to run cuttlefish builds on Windows.

Once merged, someone in the Kyorai org will have to create an AppVeyor account and enable the build. When logged in to AppVeyor using my GitHub credentials, I don't see any repos listed from Kyorai, presumably because I am not a member of that org.

You can see AppVeyor builds of my fork here

@lukebakken lukebakken requested a review from Licenser August 5, 2019 15:02
Copy link
Member

@Licenser Licenser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I’ll add a appvoyer trigger later today unless anyone else has objections

@lukebakken
Copy link
Collaborator Author

Thanks @Licenser ! I don't think you'll have to make any custom configuration once the build is enabled, the appveyor.yml file should take care of it.

@lukebakken lukebakken merged commit caf9116 into Kyorai:develop Aug 5, 2019
@lukebakken lukebakken deleted the lrb-windows-build branch August 5, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants