new datatype 'fqdn' #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
approved these changes
Mar 24, 2021
|
I like it. Thank you! |
|
This went into |
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have
'fqdn'as a new datatype, separate from the existing'ip'but with the convenience of parsing"example.com:2020"into{"example.com", 2020}that the latter comes with.FQDNs, as opposed to ip addresses, are used in riak_cs.schema, and tests existing in 2.1 are broken with the current cuttlefish. This is because it now (in contrast to cuttlefish used in riak_cs 2.1, passes the IPString to
inet:parse_address/1.I made the changes to support this new type in that introduces this new datatype, kindly for your review.