Replace Lager with OTP logger #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuttlefish is already functional at this point. Tests use a custom lager backend and need updating.
It's not entirely identical to the previous one because default time formatting is different from Lager but we'll assume it's acceptable for Cuttlefish. Compare, with Lager: 15:12:26.054 [info] No app.config or vm.args detected in /etc, activating cuttlefish to the OTP logger version on OTP 24: 2021-03-08T15:14:55.963768+03:00 [info] No app.config or vm.args detected in /etc, activating cuttlefish
dumbbell
requested changes
Mar 8, 2021
per suggestion from @dumbbell
|
Tested against a RabbitMQ branch that uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we can require OTP 22 and strive to support OTP 24, Lager is both no longer necessary and makes it harder to work on OTP 24 compatibility.
Closes #19.