Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inclusion of other .conf files #13

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

lrascao
Copy link
Contributor

@lrascao lrascao commented Nov 5, 2020

Through the include directive one can either include
a single .conf file or many with glob patterns, eg.:
include a_file.conf
include many_files_dir/*.conf

@lrascao lrascao force-pushed the feature/conf_file_inclusion branch from 056fe3e to 76a42f9 Compare November 5, 2020 18:26
Through the `include` directive one can either include
a single .conf file or many with glob patterns, eg.:
    include a_file.conf
    include many_files_dir/*.conf
@lrascao lrascao force-pushed the feature/conf_file_inclusion branch from 76a42f9 to 4d20eb7 Compare November 9, 2020 17:06
@lukebakken lukebakken self-requested a review November 25, 2020 15:49
@lukebakken lukebakken self-assigned this Nov 25, 2020
@lukebakken lukebakken added this to the 2.5.0 milestone Nov 25, 2020
@@ -20,7 +20,6 @@
%% conf_parse: for all your .conf parsing needs.
%%
%% Copyright (c) 2013 Basho Technologies, Inc. All Rights Reserved.
%% Copyright (c) 2019 Pivotal Software, Inc. All rights reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed this, i guess this is being manually added to the generated parser, do we want to keep it? @lukebakken

Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukebakken lukebakken merged commit f8af6f2 into Kyorai:master Nov 30, 2020
@lrascao lrascao deleted the feature/conf_file_inclusion branch December 2, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants