-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CH-358]Support json_tuple function #361
[CH-358]Support json_tuple function #361
Conversation
Can one of the admins verify this patch? |
test this please |
please add a gluten pr to add some ut for this function, thanks |
ok |
e03a0be
to
54edb9b
Compare
ut added done in gluten pr: apache/incubator-gluten#1135. Thanks for your review @zzcclp |
test this please |
test this please with 1135 |
1 similar comment
test this please with 1135 |
@@ -700,7 +700,7 @@ QueryPlanPtr SerializedPlanParser::parse(std::unique_ptr<substrait::Plan> plan) | |||
ActionsDAGPtr actions_dag = std::make_shared<ActionsDAG>(blockToNameAndTypeList(query_plan->getCurrentDataStream().header)); | |||
NamesWithAliases aliases; | |||
auto cols = query_plan->getCurrentDataStream().header.getNamesAndTypesList(); | |||
for (int i = 0; i < root_rel.root().names_size(); i++) | |||
for (int i = 0; i < cols.getNames().size(); i++) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里有编译警告
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix done. @liuneng1994
0453e1a
to
f6be52b
Compare
test this please with 1135 |
bd04970
to
1ec3fef
Compare
test this please with 1135 |
@liuneng1994 cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Implement json_tuple funtion by use JSONExtract function in ck, the releated issue: #358