lib: Stop using bitflags to declare FFI definitions. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using bitflags for FFI is unsound in linux32, and it causes crashes like https://bugzilla.mozilla.org/show_bug.cgi?id=1406952. This is pretty similar to rust-lang/rust-bindgen#439. For this to be properly type safe we need to wait for rust-lang/rust#43036. Hopefully that's not for too long.
|
r? @KyleMayes |
|
@KyleMayes ping? It'd be nice to get this in soon, if you can, in order to unblock building firefox in 32-bit devices. I can also avoid using these functions in bindgen, but that's really a last-resort solution... |
|
Done, sorry for the delay. |
|
no worries, thanks a lot, as always :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using bitflags for FFI is unsound in linux32, and it causes crashes like
https://bugzilla.mozilla.org/show_bug.cgi?id=1406952.
This is pretty similar to rust-lang/rust-bindgen#439.
For this to be properly type safe we need to wait for rust-lang/rust#43036.
Hopefully that's not for too long.