React 18 #1195
Merged
React 18 #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto Deploy Pull RequestYour domain kyberswap-interface-1195.pr.kyberengineering.io has been created. Notes
|
namgold
reviewed
Aug 4, 2022
Signed-off-by: Nam Nguyen <nam.nguyen@kyber.network>
Signed-off-by: Nam Nguyen <nam.nguyen@kyber.network>
hungdoansy
reviewed
Aug 4, 2022
| @@ -80,23 +82,19 @@ const MenuFlyout = (props: { | |||
| hasArrow?: boolean | |||
| }) => { | |||
| useOnClickOutside(props.node, props.isOpen && !isMobile ? props.toggle : undefined) | |||
| const BrowserStyle = useMemo( | |||
There was a problem hiding this comment.
I think we should keep useMemo. This PR shouldn't update logics where it's not needed to update
There was a problem hiding this comment.
this violate rule of hook
There was a problem hiding this comment.
This is probably because the SC is used dynamically (inside another component)
Signed-off-by: Nam Nguyen <nam.nguyen@kyber.network>
namgold
approved these changes
Aug 5, 2022
Auto Deploy Pull RequestYour domain kyberswap-interface-1195.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade: