feat: improvement-add failed to switch network message #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto Deploy Pull RequestYour domain dmm-interface-1188.pr.kyberengineering.io has been created. Notes
|
viet-nv
requested changes
Aug 2, 2022
src/components/Web3Status/index.tsx
Outdated
| @@ -176,11 +181,11 @@ function Web3StatusInner() { | |||
| {!hasPendingTransactions && connector && <StatusIcon connector={connector} />} | |||
| </Web3StatusConnected> | |||
| ) | |||
| } else if (error) { | |||
| } else if (error || switchNetworkErrorId) { | |||
There was a problem hiding this comment.
why do we show wrong network here?
I think we dont need switchNetworkErrorId state, just show popup error is ok
There was a problem hiding this comment.
Don't know. I just follow the design. https://www.figma.com/file/RzMXwwz34wZnijmvKWnvza/KyberSwap?node-id=17929%3A178938
There was a problem hiding this comment.
I discussed with Linh, He agrees that we can remove wrong network error, just show error popup is enough
TienPQ149
force-pushed
the
Improvement_add_failed_to_switch_network_message
branch
from
ef72b9f to
9697356
Compare
viet-nv
approved these changes
Aug 2, 2022
Auto Deploy Pull RequestYour domain kyberswap-interface-1188.pr.kyberengineering.io has been created. Notes
|
TienPQ149
force-pushed
the
Improvement_add_failed_to_switch_network_message
branch
from
a31f892 to
539e30a
Compare
viet-nv
changed the title
Auto Deploy Pull RequestYour domain kyberswap-interface-1188.pr.kyberengineering.io has been revoked because: PR closed. Notes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.