This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Append tokens from uniswap default list #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hungdoansy
commented
Aug 5, 2022
hungdoansy
commented
- Append tokens from uniswap default list
- This PR also removes tokens that are not found on CoinMarketCap
hungdoansy
requested review from
namgold and
viet-nv
and removed request for
namgold
viet-nv
reviewed
Aug 8, 2022
hungdoansy
force-pushed
the
append-tokens-from-uniswap-default-list
branch
from
a41de89 to
a076750
Compare
namgold
reviewed
Aug 8, 2022
tokenLists/rinkeby.tokenlist.json
Outdated
| "symbol": "MKR", | ||
| "decimals": 18, | ||
| "chainId": 4, | ||
| "logoURI": "https://raw.githubusercontent.com/trustwallet/assets/master/blockchains/ethereum/assets/0xF9bA5210F91D0474bd1e1DcDAeC4C58E359AaD85/logo.png" |
namgold
approved these changes
Aug 8, 2022
namgold
reviewed
Aug 8, 2022
| @@ -384,7 +384,7 @@ | |||
| "name": "Band Protocol", | |||
| "symbol": "BAND", | |||
| "decimals": 18, | |||
| "logoURI": "https://assets.coingecko.com/coins/images/9545/thumb/band-protocol.png?1568730326" | |||
| "logoURI": "https://s2.coinmarketcap.com/static/img/coins/64x64/4679.png" | |||
There was a problem hiding this comment.
namgold
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.