optimize resourceconsist controller events #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaofan-hs
force-pushed
the
event-style
branch
7 times, most recently
from
ba75c33 to
b9c0aeb
Compare
| employer.GetObjectKind().GroupVersionKind().Kind, employer.GetNamespace(), employer.GetName())) | ||
| r.recorder.Eventf(employer, corev1.EventTypeWarning, "GetCurrentEmployeeFailed", | ||
| "get current employees failed: %s", err.Error()) | ||
| logger.Error(err, "get current employees failed") | ||
| return reconcile.Result{}, err |
There was a problem hiding this comment.
should we ignore this event? same to GetExpectEmployeeFailed
| return reconcile.Result{}, err | ||
| } | ||
| } | ||
|
|
||
| r.recorder.Eventf(employer, corev1.EventTypeNormal, "ReconcileSucceed", "") |
There was a problem hiding this comment.
I noticed that some events ignored. Could u explain why those events ignored and how to choose what events should be remained?
There was a problem hiding this comment.
Generally speaking, event is for common users, and log is for controller developers, we can separate them for better performance. If we meet a problem, we can firstly view the events, then if we need more detail message, we can search the logs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re KusionStack/kuperator#172
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.