Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resources that have not changed are still being updated when using the apply command with the ignore-fields flag #378

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

The ignore-fields flag is functional only during the preview stage and cannot be utilized during the apply stage.

Which issue(s) this PR fixes:

Fixes #376

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix resources that have not changed are still being updated when using the apply command with the ignore-fields flag.

Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan requested a review from healthjyk July 11, 2023 03:46
@SparkYuan SparkYuan enabled auto-merge (squash) July 11, 2023 03:48
@SparkYuan SparkYuan changed the title add IgnoreFields in apply Fix resources that have not changed are still being updated when using the apply command with the ignore-fields flag Jul 11, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5515577414

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 71.771%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 5386655820: 0.04%
Covered Lines: 4874
Relevant Lines: 6791

💛 - Coveralls

@SparkYuan SparkYuan requested a review from liu-hm19 July 11, 2023 12:34
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit ff94a11 into KusionStack:main Jul 12, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resources that have not changed are still being updated
4 participants