Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image tag error in Helm #46

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

z1cheng
Copy link
Contributor

@z1cheng z1cheng commented Jul 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix KusionStack/karpor#561

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Tested it locally:
QQ_1722355761655

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@elliotxx
Copy link
Collaborator

@z1cheng I tested two case and they both worked fine. Good job!

image

@elliotxx
Copy link
Collaborator

@z1cheng Hi you still need to do a little work. 🤏 The Ci Lint is not passed because the template is modified. You need the bump chart version to 0.5.6 👇, and then execute the make doc to update readme in ./charts/karpor

image

Signed-off-by: z1cheng <imchench@gmail.com>
@z1cheng
Copy link
Contributor Author

z1cheng commented Jul 31, 2024

@elliotxx Updated, please trigger the workflow again.

Copy link
Collaborator

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit acaa214 into KusionStack:master Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation: Fix the ErrImagePull of using helm to specify the server.image.tag
2 participants