Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize karpor chart including directory structure, definition etc #35

Merged
merged 9 commits into from
Jul 19, 2024

Conversation

elliotxx
Copy link
Collaborator

@elliotxx elliotxx commented Jul 18, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@elliotxx elliotxx requested a review from ruquanzhao July 18, 2024 09:26
@elliotxx elliotxx changed the title refactor: optimize karpor chart including directory structure, variables etc refactor: optimize karpor chart including directory structure, definition etc Jul 18, 2024
Copy link
Collaborator

@ruquanzhao ruquanzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elliotxx elliotxx enabled auto-merge July 18, 2024 13:27
@elliotxx elliotxx requested a review from ruquanzhao July 18, 2024 13:30
@elliotxx elliotxx merged commit d445f45 into master Jul 19, 2024
1 check passed
@Eikykun Eikykun deleted the refactor-karpor-chart branch July 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants