Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hash headers only. #13

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Use hash headers only. #13

merged 1 commit into from
Oct 28, 2020

Conversation

bwplotka
Copy link
Collaborator

Ported from planetscale@d4f14cc

cc @planetscale

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

@bwplotka
Use hash headers only.
aeec34c 
Ported from planetscale/markdownfmt@d4f14cc

cc @planetscale

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
@bwplotka bwplotka mentioned this pull request Oct 27, 2020
Open
Kunde21
Kunde21 approved these changes Oct 28, 2020
View reviewed changes
Copy link
Owner

@Kunde21 Kunde21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, these result in the same md structure, so we're fighting with preference. I'll create an issue to allow hash headers as default, but make optional the underline pattern.

@Kunde21 Kunde21 mentioned this pull request Oct 28, 2020
Closed
@Kunde21 Kunde21 merged commit cfdc058 into Kunde21:master Oct 28, 2020
@bwplotka
Copy link
Collaborator Author

Oh yes, definitely - flag based would od 💪

@bwplotka bwplotka deleted the planetscale-headers branch October 28, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kunde21 Kunde21 Kunde21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwplotka @Kunde21