-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cardinally orientable blocks and shuffle asset generation code #459
Add Cardinally orientable blocks and shuffle asset generation code #459
Conversation
I can also port this to 1.19 if wanted, although i know the 6.0 rewrite is coming so that may need to wait |
I have just realized a flaw in this, the Block object returned does not extend BasicBlockJS, so behaviours like random ticking and waterlogging do not function properly. |
Another potential problem: the hitbox does not rotate when the state changes. Should be an easy enough fix |
…ric generate assets method
…nd rename the kubejs type to cardinal
…side texture if no other texture is set.
89f45c1
to
3a8fc21
Compare
This should be ready to merge now. |
This also shuffles asset generation around sot it is now in five different methods.
generateAssetJsons
no longer directly generates the assets. Instead it passes that on togenerateBlockStateJson
,generateBlockModelJsons
andgenerateItemModelJson
. This makes it so that subclasses only need to override the necessary methods.The fifth method is
generateMultipartBlockstateJson
inMultipartShapedBlockBuilder
, which should be used for blocks such as fences and walls that use multipart blockstates.All KubeJS block builders now use this system, meaning that ones that used to remove the checks for the user overriding a model/blockstate json should no longer do that.
This should also not break addons that still override
generateAssetJsons
.