Move selectors to expressions in dev environment #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
eguzki
reviewed
Nov 12, 2024
| "key": "user_id" | ||
| "expression": { | ||
| "key": "user_id", | ||
| "value": "string(getHostProperty(['metadata', 'filter_metadata', 'envoy.filters.http.header_to_metadata', 'user_id']))" |
There was a problem hiding this comment.
shouldn't be auth.somthing?
There was a problem hiding this comment.
No this one is coming from the header_to_metadata filter proving we can get filter state from non-kuadrant filters
eguzki
reviewed
Nov 12, 2024
| "key": "user_id" | ||
| "expression": { | ||
| "key": "user_id", | ||
| "value": "string(getHostProperty(['metadata', 'filter_metadata', 'envoy.filters.http.header_to_metadata', 'user_id']))" |
There was a problem hiding this comment.
I wonder what would be required if the auth step is configured using gateway capabilities like Security Policy (but not used for ext auth service, but jwt for instance.
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
eguzki
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.headersdebuglog for therequest.headersmap