Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Testing #120

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Update Testing #120

merged 2 commits into from
Oct 30, 2024

Conversation

didierofrivia
Copy link
Member

This PR updates the integration tests using the new Cel based predicates instead of our Pattern Expression based matches

@didierofrivia
[docs] Extending the TODO info regarding the panic
83a5354 
Signed-off-by: dd di cesare <didi@posteo.net>
@didierofrivia
[tests] Using predicates instead of matches
21c8b1e 
Signed-off-by: dd di cesare <didi@posteo.net>
@didierofrivia didierofrivia marked this pull request as ready for review October 28, 2024 10:40
adam-cattermole
adam-cattermole approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@didierofrivia didierofrivia merged commit f99a3f0 into main Oct 30, 2024
9 checks passed
@didierofrivia didierofrivia deleted the update-testing branch October 30, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-cattermole adam-cattermole adam-cattermole approved these changes

@alexsnaps alexsnaps Awaiting requested review from alexsnaps

@eguzki eguzki Awaiting requested review from eguzki

Assignees
No one assigned
Labels
None yet
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didierofrivia @adam-cattermole