-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout configurable #101
Timeout configurable #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, this seems to be working well! I also verified by changing one of the integration test configs and could see the timeout in the grpc request change. Just needs a rebase I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, modulo that one comment on the negative durations. But this is internal again, so not a big deal, tho I'd create an issue if we don't fix it now in place. Thanks 🙏
E: Error, | ||
{ | ||
match duration(Arc::new(string)) { | ||
Ok(Value::Duration(duration)) => Ok(Timeout(duration.to_std().unwrap())), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be an issue here, if I understand this right a "CelDuration
" can be negative, a std can't if I'm not mistaken. So we expose it as if it could, then would panic if one would provide a negative one, which would be nonsensible in any case tho...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct, this would panic on a negative as OutOfRangeError(())
Signed-off-by: dd di cesare <didi@posteo.net>
Signed-off-by: dd di cesare <didi@posteo.net>
Signed-off-by: dd di cesare <didi@posteo.net>
1361286
to
c970dd3
Compare
Closes #93
Example config:
The timeout value must be string, and must be in the format of a duration. Default to
20ms
Examples of valid timeout values: