Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/helpers/loghttp.go: remove unused code #99

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Sep 8, 2023

No description provided.

@eguzki eguzki requested a review from a team September 8, 2023 10:06
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #99 (693b37d) into main (3037c95) will increase coverage by 3.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   50.56%   53.97%   +3.41%     
==========================================
  Files          13       12       -1     
  Lines         888      867      -21     
==========================================
+ Hits          449      468      +19     
+ Misses        398      363      -35     
+ Partials       41       36       -5     
Flag Coverage Δ
unit 53.97% <ø> (+3.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🥇

@eguzki eguzki merged commit 3ddcadc into main Sep 8, 2023
@eguzki eguzki deleted the remove-unused-code branch September 8, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants