Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov: add target and threshold #104

Merged
merged 1 commit into from
Oct 2, 2023
Merged

codecov: add target and threshold #104

merged 1 commit into from
Oct 2, 2023

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 2, 2023

What

Added Codecov Status Check target and threshold

target is the minimum coverage ratio that the commit must meet to be considered a success.

threshold allows the coverage to drop by X%, and posting a success status.

❯ cat .github/codecov.yaml | curl --data-binary @- https://codecov.io/validate
Valid!

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.24%. Comparing base (48f950c) to head (2cc9caf).
Report is 173 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   53.97%   52.24%   -1.74%     
==========================================
  Files          12       12              
  Lines         867      867              
==========================================
- Hits          468      453      -15     
- Misses        363      374      +11     
- Partials       36       40       +4     
Flag Coverage Δ
integration 53.69% <ø> (-4.83%) ⬇️
unit 51.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 100.00% <ø> (ø)
pkg/helpers (u) 9.75% <ø> (ø)
pkg/log (u) 31.81% <ø> (ø)
pkg/reconcilers (u) 26.60% <ø> (ø)
pkg/limitador (u) 72.02% <ø> (ø)
controllers (i) 53.69% <ø> (-4.83%) ⬇️

see 2 files with indirect coverage changes

@eguzki eguzki requested a review from a team October 2, 2023 08:44
Copy link
Contributor

@KevFan KevFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@eguzki eguzki merged commit d1245e2 into main Oct 2, 2023
@eguzki eguzki deleted the codecov-config branch October 2, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants