Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limitador cluster envoy filter leverages DAG #528

Closed
wants to merge 1 commit into from

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Apr 9, 2024

What

Limitador cluster envoy filter controller reading from DAG Gateway API topology and RateLimitPolicies

Kuadrant rate limiting controllers no longer depends on back references annotation: kuadrant.io/ratelimitpolicies. Instead, controllers rely on the DAG Gateway API topopology to read cluster state. Kuadrant envoy filter controller is also based on this approach.

Fix reconciliation event blind spots due to race conditions or timing issues. The reconciled resource reflects latest updates from the cluster (Gateways, Routes and policies).

Built on top of #527, so that must be merged first (not a hard requirement, though)

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Merging #528 (752863b) into rate-limiting-limits-controller (9f58378) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           rate-limiting-limits-controller     #528   +/-   ##
================================================================
  Coverage                            32.47%   32.47%           
================================================================
  Files                                   67       68    +1     
  Lines                                 4745     4745           
================================================================
  Hits                                  1541     1541           
  Misses                                3120     3120           
  Partials                                84       84           
Flag Coverage Δ
unit 32.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) ∅ <ø> (∅)
api/v1beta2 (u) 52.73% <ø> (+0.71%) ⬆️
pkg/common (u) 79.62% <ø> (ø)
pkg/istio (u) 44.37% <ø> (ø)
pkg/log (u) 36.84% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 50.34% <0.00%> (-6.74%) ⬇️
controllers (i) 7.82% <0.00%> (+0.09%) ⬆️
Files Coverage Δ
api/v1beta2/ratelimitpolicy_types.go 16.98% <ø> (+0.61%) ⬆️
controllers/rate_limiting_wasmplugin_controller.go 0.00% <0.00%> (ø)
...ollers/limitador_cluster_envoyfilter_controller.go 0.00% <0.00%> (ø)
pkg/rlptools/topology_index.go 0.00% <0.00%> (ø)

@eguzki eguzki closed this Apr 9, 2024
@eguzki eguzki deleted the envoy-controller-dag branch April 9, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant