preallocate the modifiedAuthConfigs slice

Signed-off-by: Guilherme Cassolato <guicassolato@gmail.com>
Kuadrant · Nov 4, 2024 · 3401dbc · 3401dbc
1 parent 189f783
commit 3401dbc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -8,14 +8,14 @@ linters:
     - revive
     - gosec
     - stylecheck
+    - prealloc
     - tparallel
     - unconvert
     - unparam
     - whitespace
     - goimports
   disable:
     - errcheck
-    - prealloc
 
 issues:
   exclude-rules:

diff --git a/controllers/authconfigs_reconciler.go b/controllers/authconfigs_reconciler.go
@@ -65,7 +65,7 @@ func (r *AuthConfigsReconciler) Reconcile(ctx context.Context, _ []controller.Re
 	defer logger.V(1).Info("finished reconciling authconfig objects")
 
 	desiredAuthConfigs := make(map[k8stypes.NamespacedName]struct{})
-	var modifiedAuthConfigs []string
+	modifiedAuthConfigs := []string{}
 
 	for pathID, effectivePolicy := range effectivePoliciesMap {
 		_, _, _, httpRoute, httpRouteRule, _ := common.ObjectsInRequestPath(effectivePolicy.Path)
@@ -130,7 +130,9 @@ func (r *AuthConfigsReconciler) Reconcile(ctx context.Context, _ []controller.Re
 		}
 	}
 
-	state.Store(StateModifiedAuthConfigs, modifiedAuthConfigs)
+	if len(modifiedAuthConfigs) > 0 {
+		state.Store(StateModifiedAuthConfigs, modifiedAuthConfigs)
+	}
 
 	// cleanup authconfigs that are not in the effective policies
 	staleAuthConfigs := topology.Objects().Items(func(o machinery.Object) bool {