Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboards update #33

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Dashboards update #33

merged 3 commits into from
Sep 14, 2023

Conversation

Ygnas
Copy link
Collaborator

@Ygnas Ygnas commented Sep 13, 2023 •
edited
Loading

Closes: #27

  • Gateway dashboard
  • Routes Dashboards
  • Supported Features

@david-martin david-martin self-requested a review September 14, 2023 11:26
@david-martin
Copy link
Member

Very nice. Thanks for updating the dashboards @Ygnas

A couple of comments.

Looking at the supported features panel, it's great to have them listed like this
image
2 small things. Can the column title be changed to be something more meaningful?
name is fine (though maybe capitalized like others)
features (allValues) could maybe be Features ?

Would it be possible to update the screenshots in the main README as well?

@Ygnas Ygnas force-pushed the dashboards-update branch 2 times, most recently from 7bdb65a to e71fd5a Compare September 14, 2023 12:45
@Ygnas
Copy link
Collaborator Author

Ygnas commented Sep 14, 2023

Very nice. Thanks for updating the dashboards @Ygnas

A couple of comments.

Looking at the supported features panel, it's great to have them listed like this image 2 small things. Can the column title be changed to be something more meaningful? name is fine (though maybe capitalized like others) features (allValues) could maybe be Features ?

Would it be possible to update the screenshots in the main README as well?

All suggestions are done.

david-martin
david-martin approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@david-martin david-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Ygnas for putting together these changes.

@david-martin david-martin merged commit 4b3f083 into Kuadrant:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-martin david-martin david-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dashboard: Update Dashboards to Reflect Recent Changes
2 participants
@Ygnas @david-martin