release: 2023.1

* chore(Tooling): Add ruff

* chore: small change to async exception logging

* bug(SpellTool): Fix spell tool no longer working for selections

* chore: Upgrade js packages

* chore: Cleanup sync tool calls

* bug(SpellTool): Fix spell tool fill colour jank

* bug(SpellTool): Fix contextmenu opening on right-click

* bug(SpellTool): Fix spell->select activation

* bug(SpellTool): Fix "is public" label wrongly being attached to the range input box

* feat(SpellTool): Rework range concept

* chore(Typing): Mandate function style in interfaces

* feat(Shape): Add change asset button

* lang: Change edit dialog header

* feat(UI): Add quick access toggle bar + fake player toggle

* feat(Initiative): Add new Initiative "active" state

* bug(Css): Some weird firefox css change fix

* bug(Initiative): Fix initiative UI immediately closing when not active in certain cases

* feat(UI): Add modal stacking

* feat(UI): Close modals with escape

* chore(CI): Cancel in progress actions on push

* bug(FakePlayer): Hide DM layer when fake-player is active

* feat(Initiative): Limit movement during initiative

* chore(Refactor): refactor gameStore

* chore: update Dockerfile to reduce the image size

* chore: eslint changes

* bug(AdminSettings): Fix removing last DM being possible

* bug(Assets): Fix asset default stroke colour being set wrongly

* feat(Dice): Add min-height to dice tool UI

* bug(Trackers): Fix some missing client-side access checks

* chore(dependencies): Upgrade black

* bug(UI): Fix some DM elements being visible to players

* bug(Draw): drawing no longer working if vision or movement is blocked

* bug(Prompt): Fix validation function cache

* bug(AssetManager): Fix asset path handling

* bug(Resize): Fix botright resize while rotated

* bug(UI): Fix token direction UI trigger

* bug(UI): Fix floor detail positioning when menu is open

* bug(Tracker): Fix shared for all variants tracker not being able to use display on token

* bug(Select): Fix locked shape snapping

* bug(UI): Fix token direction UI rendering (#1175)

* build(deps): bump json5 from 1.0.1 to 1.0.2 in /client (#1141)

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump json5 and dependency-cruiser in /client (#1176)

Bumps [json5](https://github.com/json5/json5) to 2.2.3 and updates ancestor dependency [dependency-cruiser](https://github.com/sverweij/dependency-cruiser). These dependencies need to be updated together.


Updates `json5` from 2.2.1 to 2.2.3
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

Updates `dependency-cruiser` from 12.1.0 to 12.7.1
- [Release notes](https://github.com/sverweij/dependency-cruiser/releases)
- [Changelog](https://github.com/sverweij/dependency-cruiser/blob/develop/CHANGELOG.md)
- [Commits](sverweij/dependency-cruiser@v12.1.0...v12.7.1)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
- dependency-name: dependency-cruiser
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bug(Access): Fix keybinds not checking access

* bug(Templates): Fix custom templates no longer working properly

* bug(Groups): Fix group creation not immediately adding members

* bug(Groups): Fix shape context menu using wrong way to calculate group size

* bug(AssetManager): Close contextmenu on scroll

* bug(DmSettings): Fix invite url not including subpath if configured

* bug(Initiative): Fix adding multiple shapes to initiative always prompting for group handling

* bug(AssetManager): Fix context menu appearing in wrong location when scrolled

* bump to 2023.1

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Thomas Durieux <5577568+tdurieux@users.noreply.github.com>
Co-authored-by: rexy712 <2442544+rexy712@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

.github/workflows/pull_request.yaml

@@ -1,5 +1,8 @@
 on: pull_request
 name: PR
+concurrency:
+    group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+    cancel-in-progress: true
 jobs:
     CLIENT-build:
         runs-on: ubuntu-latest
@@ -53,4 +56,17 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v3
-            - uses: psf/black@stable
+            - name: black
+              uses: psf/black@stable
+            - name: Install Python
+              uses: actions/setup-python@v4
+              with:
+                  python-version: "3.10"
+            - name: Install dependencies
+              run: |
+                  python -m pip install --upgrade pip
+                  pip install ruff
+            - name: ruff
+              working-directory: server
+              run: |
+                  ruff src

CHANGELOG.md

@@ -6,9 +6,62 @@ All notable changes to this project will be documented in this file.
 [server] denotes changes only useful for the server owner\
 [tech] denotes internal changes that are only useful for code contributors\
 tech changes will usually be stripped from release notes for the public
+[lang] this is a change to some translation string
 
 ## Unreleased
 
+## [2023.1.0] - 2023-02-14
+
+### Added
+
+-   Button to change the current asset for a shape to the shape property settings
+-   [DM] Quick access togglebar under the tool bar
+    -   Fake Player
+    -   Initiative active state (see below)
+-   Initiative now has a specific "active" state
+    -   This streamlines some things and allows some further future things without relying on the initiative window being open
+    -   The Initiative vision lock setting now only triggers when initiative is active
+    -   The above setting now also properly reverts to the original vision lock when initiative is no longer active as was always intended
+    -   The initiative UI is automatically opened for everybody once initiative is started. (and automatically closed as well)
+    -   The above behaviour can be disabled by a new user setting.
+    -   A new DM setting (under Varia) can be enabled to limit (non-DM) initiated movement only to the active initiative shape.
+-   Most modals will now move to the front when interacted with
+-   Most modals can be closed with escape
+
+### Changed
+
+-   Spell tool
+    -   range property is removed as it was confusing to people and a bit fiddly
+    -   a ruler is now automatically drawn between the spell shape and the selected shape
+-   Dice tool: Add min-height in dice tool UI where the dice to roll are being prepared
+-   [lang] The edit dialog for shapes now properly says "Edit shape" instead of "Edit asset"
+
+### Fixed
+
+-   Spell tool: spell on selection bugged
+-   Spell tool: fill colour behaving janky when border colour has <1 opacity
+-   Spell tool: right-click was opening the context-menu
+-   Spell tool: once used, the select tool was not being properly activated
+-   Spell tool: the 'is public' label was wrongly attached to the range input box
+-   Fake Player: showing DM layer
+-   DM settings: Fix last DM being able to demote themselves to a player
+-   DM settings: Fix invite URL not containing subpath if set
+-   Assets: default stroke colour wrongly set, causing badges to be transparent
+-   Trackers: Display on token not working for trackers that are shared across variants
+-   Some cases where a client could edit shape info without access
+    -   _this was always rejected by the server and never synced_
+    -   most tracker properties
+    -   defeated and locked state using keybinds
+-   Prompt modals sometimes still using a validation check from an earlier prompt
+-   Resizing the botright corner of a rectangle-based shape while rotated was moving the shape
+-   Token direction UI triggering when other UI is on top of it
+-   Floor detail UI not moving along if side menu is opened
+-   Unlocking shape could sometimes trigger the shape following your mouse
+-   Templates: only using the first character of the provided template name
+-   Asset Manager: close contextmenu when scrolling
+-   Asset Manager: contextmenu appearing in the wrong location when scrolled
+-   Adding multiple shapes to group always prompting group question even if no groups are present
+
 ## [2022.3.0] - 2022-12-12
 
 ### Added

Dockerfile

@@ -10,13 +10,13 @@ WORKDIR /usr/src/admin-client
 
 # Copy first package.json so changes in code dont require to reinstall all npm modules
 COPY admin-client/package.json admin-client/package-lock.json ./
-RUN npm i
+RUN npm i && npm cache clean --force;
 
 WORKDIR /usr/src/client
 
 # Copy first package.json so changes in code dont require to reinstall all npm modules
 COPY client/package.json client/package-lock.json ./
-RUN npm i
+RUN npm i && npm cache clean --force;
 
 ARG PA_BASEPATH="/"
 
@@ -53,7 +53,7 @@ VOLUME /planarally/static/assets
 
 ENV PA_GIT_INFO docker:${DOCKER_TAG}-${SOURCE_COMMIT}
 
-RUN apt-get update && apt-get install dumb-init curl libffi-dev libssl-dev gcc -y && \
+RUN apt-get update && apt-get install --no-install-recommends dumb-init curl libffi-dev libssl-dev gcc -y && \
     rm -rf /var/lib/apt/lists/*
 
 # Copy first requirements.txt so changes in code dont require to reinstall python requirements

admin-client/.eslintrc.js

@@ -1,7 +1,7 @@
 module.exports = {
     extends: ["plugin:vue/vue3-recommended", "prettier"],
     rules: {
-        "vue/html-indent": off,
+        "vue/html-indent": 0,
         "vue/html-self-closing": 0,
         "vue/max-attributes-per-line": 0,
     },

client/.env

@@ -1,2 +1,2 @@
-VUE_APP_I18N_LOCALE=en
-VUE_APP_I18N_FALLBACK_LOCALE=en
+VITE_APP_I18N_LOCALE=en
+VITE_APP_I18N_FALLBACK_LOCALE=en

client/.eslintrc.js

@@ -1,15 +1,21 @@
 module.exports = {
-    root: true,
-    env: {
-        node: true,
-    },
-    extends: ["eslint:recommended", "plugin:@typescript-eslint/recommended", "plugin:vue/vue3-essential"],
+    extends: [
+        "plugin:vue/vue3-recommended",
+        "prettier",
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking",
+        "plugin:@typescript-eslint/strict",
+        "plugin:import/recommended",
+        "plugin:import/typescript",
+    ],
     rules: {
         "@typescript-eslint/await-thenable": 2,
         "@typescript-eslint/consistent-type-assertions": [2, { assertionStyle: "as" }],
         "@typescript-eslint/consistent-type-imports": 2,
         "@typescript-eslint/explicit-function-return-type": [2, { allowExpressions: true }],
         "@typescript-eslint/explicit-member-accessibility": [2, { accessibility: "no-public" }],
+        "@typescript-eslint/method-signature-style": "error",
         "@typescript-eslint/no-angle-bracket-type-assertion": "off",
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-explicit-any": "off",
@@ -18,6 +24,9 @@ module.exports = {
         "@typescript-eslint/no-use-before-define": 0,
         "@typescript-eslint/require-await": "error",
         "@typescript-eslint/strict-boolean-expressions": 2,
+        "@typescript-eslint/no-unnecessary-condition": 0,
+        "@typescript-eslint/no-dynamic-delete": 0, // to check into
+        "@typescript-eslint/consistent-type-imports": "error",
         "prefer-const": [process.env.CI === undefined ? 1 : 2],
         "import/no-unused-modules": [process.env.CI === undefined ? 0 : 2, { unusedExports: true }],
         "import/order": [
@@ -35,18 +44,17 @@ module.exports = {
         "no-dupe-class-members": "off",
         "no-empty-function": "off",
         "no-unused-vars": "off",
-        "prettier/prettier": [process.env.CI === undefined ? 1 : 2],
+        // "prettier/prettier": [process.env.CI === undefined ? 1 : 2],
         "vue/multi-word-component-names": "off",
     },
     overrides: [
         {
-            files: ["**/__tests__/*.{j,t}s?(x)", "**/tests/unit/**/*.spec.{j,t}s?(x)"],
-            env: {
-                jest: true,
+            files: "*.vue",
+            rules: {
+                "import/default": 0,
             },
         },
     ],
-    plugins: ["@typescript-eslint", "import", "prettier"],
     settings: {
         "import/resolver": {
             typescript: {
@@ -55,6 +63,7 @@ module.exports = {
         },
         "import/extensions": [".ts", ".vue"],
     },
+    parser: "vue-eslint-parser",
     parserOptions: {
         parser: "@typescript-eslint/parser",
         ecmaFeatures: {
@@ -64,10 +73,4 @@ module.exports = {
         tsconfigRootDir: __dirname,
         extraFileExtensions: [".vue"],
     },
-    globals: {
-        defineProps: "readonly",
-        defineEmits: "readonly",
-        defineExpose: "readonly",
-        withDefaults: "readonly",
-    },
 };