Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dyngen #119

Merged
merged 9 commits into from
Mar 3, 2021
Merged

Conversation

aarthivenkat
Copy link

@aarthivenkat aarthivenkat commented Feb 18, 2021

Dyngen is a multi-modal simulation engine for studying dynamic cellular processes at single-cell resolution. The backbone of a dyngen model determines the overall dynamic process that a cell will undergo during a simulation. It consists of a set of gene modules, which regulate each other in such a way that expression of certain genes change over time in a specific manner.

dyngen.py consists of three functions to (1) install dyngen (2) get a list of backbones, and (3) generate simulated datasets. Generating simulated datasets by default will return a cell_info dataframe and an expression dataframe. Optional arguments offer ground truth regulatory networks (bulk and cellwise) and RNA velocity measurements.

More information at https://github.com/dynverse/dyngen.

Copy link
Contributor

@scottgigante scottgigante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks Aarthi! Some changes but overall looks great.

scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
@scottgigante scottgigante changed the base branch from master to dev February 18, 2021 19:05
Copy link
Contributor

@scottgigante scottgigante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close! Just a couple of minor tweaks left.

scprep/run/dyngen.py Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
scprep/run/r_function.py Outdated Show resolved Hide resolved
scprep/run/r_function.py Outdated Show resolved Hide resolved
scprep/run/dyngen.py Outdated Show resolved Hide resolved
@scottgigante
Copy link
Contributor

One more note - these formatting issues should be fixed: https://github.com/aarthivenkat/scprep/runs/1936473492?check_suite_focus=true#step:7:1

@coveralls
Copy link

coveralls commented Feb 19, 2021

Coverage Status

Coverage decreased (-0.07%) to 97.899% when pulling 168cff9 on aarthivenkat:feature/dyngen into b0566ce on KrishnaswamyLab:dev.

@scottgigante
Copy link
Contributor

Also, could you please write tests for lib and dependencies?

@scottgigante scottgigante merged commit f2daf71 into KrishnaswamyLab:dev Mar 3, 2021
@scottgigante
Copy link
Contributor

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants