remove redundant checks on projectors

forward/back projector was running checks on _density_ptr, even though
it was created/tested before.

callgrind shows that has_same_charecteristics is actually surprisingly
expensive (as it calls Array::get_index_range(), which is slow).
So now we avoid doing those checks.

This results in a (quite small) speed-up, only relevant for GPU projectors.

src/include/stir/recon_buildblock/BackProjectorByBin.h

@@ -169,7 +169,17 @@ void back_project(const RelatedViewgrams<float>&,
 
       If overriding this function in a derived class, you need to call this one.
    */
+  virtual void check(const ProjDataInfo& proj_data_info) const;
+
+  //! check if the arguments are the same as what was used for set_up()
+  /*! calls error() if anything is wrong.
+
+      If overriding this function in a derived class, you need to call this one.
+
+      Calls check(const ProjDataInfo&)
+   */
   virtual void check(const ProjDataInfo& proj_data_info, const DiscretisedDensity<3,float>& density_info) const;
+
   bool _already_set_up;
 
   //! Clone of the density sptr set with set_up()

src/include/stir/recon_buildblock/ForwardProjectorByBin.h

@@ -141,7 +141,17 @@ virtual void set_up(
 
       If overriding this function in a derived class, you need to call this one.
    */
+  virtual void check(const ProjDataInfo& proj_data_info) const;
+
+  //! check if the arguments are the same as what was used for set_up()
+  /*! calls error() if anything is wrong.
+
+      If overriding this function in a derived class, you need to call this one.
+
+      Calls check(const ProjDataInfo&)
+   */
   virtual void check(const ProjDataInfo& proj_data_info, const DiscretisedDensity<3,float>& density_info) const;
+
   bool _already_set_up;
 
   //! The density ptr set with set_up()

src/recon_buildblock/BackProjectorByBin.cxx

@@ -96,13 +96,20 @@ set_up(const shared_ptr<const ProjDataInfo>& proj_data_info_sptr,
 
 void
 BackProjectorByBin::
-check(const ProjDataInfo& proj_data_info, const DiscretisedDensity<3,float>& density_info) const
+check(const ProjDataInfo& proj_data_info) const
 {
   if (!this->_already_set_up)
     error("BackProjectorByBin method called without calling set_up first.");
   if (!(*this->_proj_data_info_sptr >= proj_data_info))
     error(boost::format("BackProjectorByBin set-up with different geometry for projection data.\nSet_up was with\n%1%\nCalled with\n%2%")
           % this->_proj_data_info_sptr->parameter_info() % proj_data_info.parameter_info());
+}
+
+void
+BackProjectorByBin::
+check(const ProjDataInfo& proj_data_info, const DiscretisedDensity<3,float>& density_info) const
+{
+  this->check(proj_data_info);
   if (! this->_density_sptr->has_same_characteristics(density_info))
     error("BackProjectorByBin set-up with different geometry for density or volume data.");
 }
@@ -265,7 +272,7 @@ back_project(const RelatedViewgrams<float>& viewgrams,
   if (!_density_sptr)
     error("You need to call start_accumulating_in_new_target() before back_project()");
 
-  check(*viewgrams.get_proj_data_info_sptr(), *_density_sptr);
+  check(*viewgrams.get_proj_data_info_sptr());
 
 #ifdef STIR_OPENMP
   const int thread_num=omp_get_thread_num();

src/recon_buildblock/ForwardProjectorByBin.cxx

@@ -81,13 +81,20 @@ set_up(const shared_ptr<const ProjDataInfo>& proj_data_info_sptr,
 
 void
 ForwardProjectorByBin::
-check(const ProjDataInfo& proj_data_info, const DiscretisedDensity<3,float>& density_info) const
+check(const ProjDataInfo& proj_data_info) const
 {
   if (!this->_already_set_up)
     error("ForwardProjectorByBin method called without calling set_up first.");
   if (!(*this->_proj_data_info_sptr >= proj_data_info))
     error(boost::format("ForwardProjectorByBin set-up with different geometry for projection data.\nSet_up was with\n%1%\nCalled with\n%2%")
           % this->_proj_data_info_sptr->parameter_info() % proj_data_info.parameter_info());
+}
+
+void
+ForwardProjectorByBin::
+check(const ProjDataInfo& proj_data_info, const DiscretisedDensity<3,float>& density_info) const
+{
+  this->check(proj_data_info);
   if (! this->_density_sptr->has_same_characteristics(density_info))
     error("ForwardProjectorByBin set-up with different geometry for density or volume data.");
 }
@@ -254,7 +261,7 @@ forward_project(RelatedViewgrams<float>& viewgrams,
   if (!_density_sptr)
     error("You need to call set_input() forward_project()");
 
-  check(*viewgrams.get_proj_data_info_sptr(), *_density_sptr);
+  check(*viewgrams.get_proj_data_info_sptr());
 
   // first check symmetries
   {