Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface improvements + bug fixing #6

Merged
merged 8 commits into from
Jan 30, 2015

Conversation

vilanovi
Copy link
Contributor

@vilanovi vilanovi commented May 7, 2014

Hello,

We are using the KILabel class in our organisation projects. However we have �refracted the interface of the KILabel class: added documentation, unified the KILinkDetectorType with the KILinkType, add getters and setters for each link type text attributes, added support for ignore keywords, and a few changes more.

Regarding bugs:

  1. We have fixed a bug that made the KILabel crash the execution when setting a nil text.
  2. There is still a bug in the �rendering of the text: the bounds are not exactly the same as a normal UILabel. This makes the KILabel be rendered in a rectangle that doesn't correspond with the method [@"string" boundingRectWithSize:options:attributes:context:] (as UILabel does). I have to study a bit more why this is happening and how to prevent it.

I don't know if you might be interested in merge our fork in your repository, in any case, I offer you a pull request and is your call to decide if you are interested or not.

Also, if you feel we must add/change something else, please, tell me and we will do it.

Thanks,

Joan

@Krelborn
Copy link
Owner

Krelborn commented May 7, 2014

Hi Joan,

Thanks for feedback, good to hear you've found it useful. I will certainly look at pulling your changes into my repository. I've had a quick look through what you've done and it all looks good. I need to go through it a bit more detail, and will get back to you if I can think of anything that needs changing.

I've added a bug issue to cover the remaining bug you've reported. That's certainly something that would be good to fix, although hopefully the rendering is good enough for most uses.

Regards,

Matt

Krelborn added a commit that referenced this pull request Jan 30, 2015
Interface improvements + bug fixing
@Krelborn Krelborn merged commit 9280a86 into Krelborn:master Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants