[Fluid-SDEM] Dynamic vms dem coupled #8018

jgonzalezusua · 2020-12-21T14:52:57Z

Description
This PR is aimed to develop the formulation of the generalized N-S equations including the porosity and using the dynamic subscales for both ASGS and OSS methods.

Please mark the PR with appropriate tags:

Feature
Application

Changelog
The changes of this PR are:

Added element called d_vms_dem_coupled.cpp derived from d_vms.cpp
Added a cpp test for the new element.
Updated navier_stokes_vms_monolithic_DEMCoupled.py to add the new element to the solver.

…data

…ment_data

…f TauP

GuillermoCasas · 2020-12-22T08:51:52Z

applications/FluidDynamicsApplication/tests/cpp_tests/test_d_vms_dem_coupled_element.cpp

+        rElem.Check(r_process_info);
+        i->CalculateLocalVelocityContribution(LHS, RHS, r_process_info);
+        std::cout.precision(10);
+        //std::cout << i->Info() << RHS << std::endl;


remove comments

In this specific case I'd keep it (these are really useful when it is required to update the test values due to a formulation upgrade or correction).

GuillermoCasas · 2020-12-22T08:54:20Z

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.cpp

+    // Auxiliary coefficient StaticTauOne*TauTwo/Dt that appears on the pressure subscale model
+    // This coefficient comes from mass equation: div(u^n+1 + u^n) = 0 setting to 0 is to consider
+    // div(u^n+1) = 0
+    TauP = 0.0;


I would remove all reference to this term. If we want, we can add it later, but it is better to leave everything clean

Indeed, aren't these the standard tau constant used in the base NS formulation? If so it is the base class method could be used.

GuillermoCasas · 2020-12-22T08:57:43Z

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.cpp

+            // Some terms are the same for all velocity components, calculate them once for each i,j
+
+            // Skew-symmetric convective term 1/2( v*grad(u)*u - grad(v) uu )
+            //double K = 0.5*(rN[i]*AGradN[j] - AGradN[i]*rN[j]);


I do not remember discussing the possibility of using this skew-symmetric form. It could be something else to study in the future

This is inherited from the d_vms.cpp, I prefer to keep this line commented.

GuillermoCasas

All minor changes

GuillermoCasas · 2020-12-22T09:01:24Z

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.h

+                            GeometryType::Pointer pGeom,
+                            Properties::Pointer pProperties) const override;
+
+    void Calculate(


Did you really need to override all these 'Calculate' functions?

Agree. Indeed in your implementation you are precluding the access to the base class ones.

rubenzorrilla · 2020-12-22T09:40:12Z

...ions/SwimmingDEMApplication/python_scripts/navier_stokes_solver_vms_monolithic_DEMCoupled.py

+            "element_name": "DVMSDEMCoupled"
+        }""")
+        settings.ValidateAndAssignDefaults(default_settings)
+


Consider the changes in #7997

Why did you include the dynamic_tau in the DVMS settings? It is not used in the element...

It is used in the base quasi-static class to calculate the stabilization constants.

rubenzorrilla · 2020-12-22T09:47:48Z

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.cpp

+    const ProcessInfo& rCurrentProcessInfo) {}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::Calculate(
+    const Variable<array_1d<double, 3>>& rVariable,
+    array_1d<double, 3>& rOutput,
+    const ProcessInfo& rCurrentProcessInfo) {
+    // Lumped projection terms
+    if (rVariable == ADVPROJ) {
+        this->CalculateProjections(rCurrentProcessInfo);
+    }
+}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::Calculate(
+    const Variable<Vector>& rVariable,
+    Vector& rOutput,
+    const ProcessInfo& rCurrentProcessInfo) {}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::Calculate(
+    const Variable<Matrix>& rVariable,
+    Matrix& rOutput,
+    const ProcessInfo& rCurrentProcessInfo) {}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::Initialize(const ProcessInfo& rCurrentProcessInfo)
+{
+    // Base class does things with constitutive law here.
+    DVMS<TElementData>::Initialize(rCurrentProcessInfo);
+}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::FinalizeSolutionStep(const ProcessInfo& rCurrentProcessInfo)
+{
+    DVMS<TElementData>::FinalizeSolutionStep(rCurrentProcessInfo);
+}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::InitializeNonLinearIteration(const ProcessInfo& rCurrentProcessInfo)
+{
+    DVMS<TElementData>::InitializeNonLinearIteration(rCurrentProcessInfo);
+}
+///////////////////////////////////////////////////////////////////////////////////////////////////
+// Inquiry
+
+template< class TElementData >
+int DVMSDEMCoupled<TElementData>::Check(const ProcessInfo &rCurrentProcessInfo) const
+{
+    int out = DVMS<TElementData>::Check(rCurrentProcessInfo);
+
+    return out;
+}
+
+///////////////////////////////////////////////////////////////////////////////////////////////////
+
+template< class TElementData >
+void DVMSDEMCoupled<TElementData>::GetValueOnIntegrationPoints(
+    Variable<array_1d<double, 3 > > const& rVariable,
+    std::vector<array_1d<double, 3 > >& rValues,
+    ProcessInfo const& rCurrentProcessInfo)
+{
+    DVMS<TElementData>::GetValueOnIntegrationPoints(rVariable,rValues,rCurrentProcessInfo);
+}
+
+template< class TElementData >
+void DVMSDEMCoupled<TElementData>::GetValueOnIntegrationPoints(
+    Variable<double> const& rVariable,
+    std::vector<double>& rValues,
+    ProcessInfo const& rCurrentProcessInfo)
+{
+    DVMS<TElementData>::GetValueOnIntegrationPoints(rVariable,rValues,rCurrentProcessInfo);
+}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::GetValueOnIntegrationPoints(
+    Variable<array_1d<double, 6>> const& rVariable,
+    std::vector<array_1d<double, 6>>& rValues,
+    ProcessInfo const& rCurrentProcessInfo)
+{
+    DVMS<TElementData>::GetValueOnIntegrationPoints(rVariable,rValues,rCurrentProcessInfo);
+}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::GetValueOnIntegrationPoints(
+    Variable<Vector> const& rVariable,
+    std::vector<Vector>& rValues,
+    ProcessInfo const& rCurrentProcessInfo)
+{
+    DVMS<TElementData>::GetValueOnIntegrationPoints(rVariable,rValues,rCurrentProcessInfo);
+}
+
+template <class TElementData>
+void DVMSDEMCoupled<TElementData>::GetValueOnIntegrationPoints(
+    Variable<Matrix> const& rVariable,
+    std::vector<Matrix>& rValues,
+    ProcessInfo const& rCurrentProcessInfo)
+{
+    DVMS<TElementData>::GetValueOnIntegrationPoints(rVariable,rValues,rCurrentProcessInfo);
+}


Why overriding all these methods?

rubenzorrilla · 2020-12-22T09:48:39Z

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.cpp

+    if (rVariable == ADVPROJ) {
+        this->CalculateProjections(rCurrentProcessInfo);
+    }


An else statement calling the base class Calculate should be added in case the provided variable it's not implemented in here.

rubenzorrilla · 2020-12-22T09:53:05Z

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.h

+    DVMSDEMCoupled(IndexType NewId, GeometryType::Pointer pGeometry, Properties::Pointer pProperties);
+
+    /// Destructor.
+    ~DVMSDEMCoupled() override;


Destructors shouldn't be override specified (see here).

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.h

GuillermoCasas

I think this is ready for merging

GuillermoCasas

PLease change what we discussed about the evaluatiion of the error at the Gauss points

jgonzalezusua added 17 commits December 15, 2020 10:50

Creation of element based on dynamic subscale with porosity

e9b6a06

Removing methods in the new element

4ac7b97

Changing minor error

30625c3

Registration of the new element and creation of the dvms_dem_coupled_…

0a69a22

…data

Modifying formulation and removing the effect of tau_p

e763658

Fixing errors

e7c4e42

Adding dvms with porosity to the DEM coupled solver

b1fc319

Modifying dvms_dem_coupled_data to be derived directly from fluid_ele…

a3b8c32

…ment_data

Move private members in d_vms to protected

dcb20c4

Changed minor errors

af96dba

Deriving d_vms_dem_coupling from d_vms again

ba91c06

Merge branch 'master' into dynamic-vms-DEM-coupled

575f1a6

Removing dvms_dem_coupled_data

18ad5ca

Fixing minors

030f376

Adding StabilizationParameters in new element to neglect the effect o…

ce7e0c7

…f TauP

Adding dvms dem coupled test

eb76c26

Merge branch 'master' into dynamic-vms-DEM-coupled

b21898e

jgonzalezusua requested review from a team as code owners December 21, 2020 14:52

jgonzalezusua requested a review from GuillermoCasas December 21, 2020 14:53

jgonzalezusua added Applications Feature labels Dec 21, 2020

jgonzalezusua changed the title ~~Dynamic vms dem coupled~~ [Fluid-SDEM] Dynamic vms dem coupled Dec 21, 2020

Fixing compilation errors

56e899c

GuillermoCasas reviewed Dec 22, 2020

View reviewed changes

GuillermoCasas requested changes Dec 22, 2020

View reviewed changes

GuillermoCasas reviewed Dec 22, 2020

View reviewed changes

rubenzorrilla reviewed Dec 22, 2020

View reviewed changes

applications/FluidDynamicsApplication/custom_elements/d_vms_dem_coupled.h Outdated Show resolved Hide resolved

jgonzalezusua added 2 commits December 27, 2020 13:37

Addressing suggestions

f3f0747

Fixing bug in L2_error_calculator_utility

6564a3f

jgonzalezusua requested a review from GuillermoCasas December 27, 2020 12:38

jgonzalezusua added 2 commits December 27, 2020 14:37

Addressing Codacy warnings

5f63d33

Addressing gcc errors

ec7bcac

GuillermoCasas approved these changes Dec 27, 2020

View reviewed changes

GuillermoCasas requested changes Dec 27, 2020

View reviewed changes

jgonzalezusua added 2 commits December 30, 2020 15:12

Fixing L2 calculator error bug

db716cb

Remove element to do the L2 interpolator

d383c55

jgonzalezusua requested a review from GuillermoCasas December 30, 2020 15:51

jgonzalezusua requested a review from rubenzorrilla January 7, 2021 12:04

GuillermoCasas approved these changes Jan 8, 2021

View reviewed changes

jgonzalezusua merged commit 8f752f3 into master Jan 8, 2021

jgonzalezusua deleted the dynamic-vms-DEM-coupled branch January 8, 2021 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fluid-SDEM] Dynamic vms dem coupled #8018

[Fluid-SDEM] Dynamic vms dem coupled #8018

jgonzalezusua commented Dec 21, 2020

GuillermoCasas Dec 22, 2020

rubenzorrilla Dec 22, 2020

GuillermoCasas Dec 27, 2020

GuillermoCasas Dec 22, 2020

rubenzorrilla Dec 22, 2020

GuillermoCasas Dec 22, 2020

jgonzalezusua Dec 22, 2020

GuillermoCasas left a comment

GuillermoCasas Dec 22, 2020

rubenzorrilla Dec 22, 2020

rubenzorrilla Dec 22, 2020

jgonzalezusua Dec 27, 2020

rubenzorrilla Dec 28, 2020

rubenzorrilla Dec 22, 2020

rubenzorrilla Dec 22, 2020

rubenzorrilla Dec 22, 2020

GuillermoCasas left a comment

GuillermoCasas left a comment

[Fluid-SDEM] Dynamic vms dem coupled #8018

[Fluid-SDEM] Dynamic vms dem coupled #8018

Conversation

jgonzalezusua commented Dec 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuillermoCasas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuillermoCasas left a comment

Choose a reason for hiding this comment

GuillermoCasas left a comment

Choose a reason for hiding this comment