[ContactStructuralMechanicsApplication] Refactor ContactUtilities to cpp #7616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
added
Applications
FastPR
loumalouomega
added
the
Refactor
applications/ContactStructuralMechanicsApplication/custom_utilities/contact_utilities.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
39
to
42
| ///@} | ||
| ///@name Namespaces | ||
| ///@{ | ||
|
|
There was a problem hiding this comment.
I think this is legacy from the previous implementation
rubenzorrilla
approved these changes
Oct 19, 2020
philbucher
reviewed
Oct 20, 2020
Comment on lines
+51
to
+66
| const int num_threads = OpenMPUtils::GetNumThreads(); | ||
| std::vector<double> max_vector(num_threads, 0.0); | ||
| double nodal_h; | ||
| #pragma omp parallel for private(nodal_h) | ||
| for(int i = 0; i < static_cast<int>(r_nodes_array.size()); ++i) { | ||
| auto it_node = it_node_begin + i; | ||
| KRATOS_DEBUG_ERROR_IF_NOT(it_node->SolutionStepsDataHas(NODAL_H)) << "ERROR:: NODAL_H not added" << std::endl; | ||
| nodal_h = it_node->FastGetSolutionStepValue(NODAL_H); | ||
|
|
||
| const int id = OpenMPUtils::ThisThread(); | ||
|
|
||
| if (nodal_h > max_vector[id]) | ||
| max_vector[id] = nodal_h; | ||
| } | ||
|
|
||
| return *std::max_element(max_vector.begin(), max_vector.end()); |
There was a problem hiding this comment.
just to say that this could be done simpler with the ParallelUtilities
There was a problem hiding this comment.
I have it in my TODO list
philbucher
reviewed
Oct 20, 2020
| #include "contact_structural_mechanics_application_variables.h" | ||
| #include "includes/model_part.h" |
There was a problem hiding this comment.
this is used in this file, I wouldn't remove
rubenzorrilla
previously approved these changes
Oct 20, 2020
There was a problem hiding this comment.
As this is only refactor I'd leave changes for a future PR. @loumalouomega and @philbucher up to you 😉
philbucher
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving ContactUtilities to cpp
Changelog